Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngSwitch has an undocument change attribute #8822

Closed
rodyhaddad opened this issue Aug 28, 2014 · 4 comments
Closed

ngSwitch has an undocument change attribute #8822

rodyhaddad opened this issue Aug 28, 2014 · 4 comments
Assignees
@caitp
Labels
component: misc core frequency: low needs: review severity: inconvenient type: chore

Comments

@rodyhaddad
Copy link
Contributor

There seems to be a change attribute that ngSwitch evaluates that isn't documented.
See in current code.

Looking at the history, this got introduced in 0df93fd back in 2010, here.

I believe we should remove it, as it seems it was never documented.

Thoughts?
@rodyhaddad rodyhaddad added this to the 1.3.0 milestone Aug 28, 2014
@lgalfaso
Copy link
Contributor

+1 to remove it

@IgorMinar
Copy link
Contributor

remove

@IgorMinar IgorMinar modified the milestones: 1.3.0-rc.1, 1.3.0 Aug 29, 2014
@thebigredgeek
Copy link
Contributor

Hey @rodyhaddad! Let me take a swing at this. Are you still in SF/MV btw? Just finished my move to PA ;)

@thebigredgeek thebigredgeek mentioned this issue Aug 30, 2014
Closed
@thebigredgeek
Copy link
Contributor

#8858

@caitp caitp closed this as completed in 0f806d9 Sep 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caitp caitp

Labels
component: misc core frequency: low needs: review severity: inconvenient type: chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@IgorMinar @lgalfaso @rodyhaddad @caitp @thebigredgeek