This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(ngSwitch): removed the change attr from ngSwitch and updated spec #8858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit message doesn't follow our format. We should document this as a breaking change since it's been in the code base since forever. |
thebigredgeek
changed the title
thebigredgeek
force-pushed
the
bugfix/removeChangeAttrNgSwitch
branch
from
ac88320 to
e1e16ba
Compare
|
grepping the source tree doesn't seem to find any mention of this attribute (but it's possible I'm using the wrong queries). Since it seems to be undocumented, +1 for removing it. |
|
This should be refractor and not chore. @caitp please fix and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8822