Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf(extend): remove use of forEach to remove calls/closures/passing arguments #8898

Closed
wants to merge 1 commit into from

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Sep 3, 2014

I found this made $parse almost 50% faster when not cached, I assume other cases will also benefit. This also removes the "bad value context for arguments value" warning in the chrome profiler.

@btford btford added this to the Backlog milestone Sep 3, 2014
@IgorMinar
Copy link
Contributor

otherwise this looks good to me

@IgorMinar IgorMinar modified the milestones: 1.3.0-rc.2, Backlog Sep 8, 2014
@IgorMinar IgorMinar self-assigned this Sep 8, 2014
@jbedard jbedard force-pushed the parser-perf branch 2 times, most recently from 2fd0c17 to db9d40a Compare September 8, 2014 04:24
@jbedard
Copy link
Contributor Author

jbedard commented Sep 8, 2014

I updated the loop to use Object.keys, this required making sure obj is truthy in the if statement as well. Might be able to remove the obj !== dst now that the loop starts at i = 1, probably does no harm either way though...

@IgorMinar IgorMinar closed this in 9bedeb3 Sep 8, 2014
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this pull request Sep 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants