Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf(extend): remove use of forEach to remove calls/closures/passing arguments #8898

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/Angular.js
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,16 @@ function setHashKey(obj, h) {
*/
function extend(dst) {
var h = dst.$$hashKey;
forEach(arguments, function(obj) {
if (obj !== dst) {
forEach(obj, function(value, key) {
dst[key] = value;
});
for (var i = 1, ii = arguments.length; i < ii; i++) {
var obj = arguments[i];
if (obj && obj !== dst) {
var keys = Object.keys(obj);
for (var j = 0, jj = keys.length; j < jj; j++) {
var key = keys[j];
dst[key] = obj[key];
}
}
});
}

setHashKey(dst,h);
return dst;
Expand Down