Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Select options won't update after changing scope's variable #9025

Closed
beefs opened this issue Sep 10, 2014 · 4 comments
Closed

Select options won't update after changing scope's variable #9025

beefs opened this issue Sep 10, 2014 · 4 comments

Comments

@beefs
Copy link

beefs commented Sep 10, 2014

Hi,
Select wont update it's options since 1.2.22 when we change the the scope variable.

example:
1.2.21:
http://jsfiddle.net/uLdmH/33/
1.2.22:
http://jsfiddle.net/uLdmH/34/

Thanks.

@mluiten
Copy link

mluiten commented Sep 11, 2014

I'm experiencing the same issue. I think it's due to a optimization in the rendering of the select directive in v1.2.22. It's now watching changes in the given options, but not changes in the labels (or values or anything else for that matter).

Not sure if this was an unintended feature, but we've come to rely on it for pluralizing options based on the value of a model. So I'm hoping we can at least retain this features for labels.

I'll submit a patch shortly.

@gkalpak
Copy link
Member

gkalpak commented Sep 11, 2014

Just verifying that it is also an issue for 1.3.0-rc.1:
http://jsfiddle.net/ExpertSystem/uLdmH/35/

@btford
Copy link
Contributor

btford commented Sep 11, 2014

@mluiten – FYI you should submit PRs against master in the future. We cherry-pick PRs to the stable branch.

Your change also needs a test.

btford added a commit to btford/angular.js that referenced this issue Sep 11, 2014
btford added a commit to btford/angular.js that referenced this issue Sep 12, 2014
@btford btford self-assigned this Sep 12, 2014
@tbosch tbosch modified the milestones: 1.3.0-rc.2, 1.3.0-rc.3 Sep 15, 2014
btford added a commit to btford/angular.js that referenced this issue Sep 16, 2014
@btford btford closed this as completed in 4627410 Sep 16, 2014
@wilgert
Copy link

wilgert commented Oct 16, 2014

The commit that fixed this causes problems in our application.
On a certain form we have several text fields and 1 select field containing 248 options (it's a country selector).

Since this commit: 4627410 entering data in any field of the form has become very slow on fast computers with Chrome and near impossible on slower computers and Internet Explorer (other browsers not tested yet).

By slow I mean that letters appear between several 100 milliseconds and several seconds after a keystroke.

Is there anything I can do about this or is the code in this commit should be improved because it is sub-optimal?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants