Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

angular-1.3.0 rc1 ngModel nonassign error in ngCsp mode #9048

Closed
graynote opened this issue Sep 12, 2014 · 4 comments
Closed

angular-1.3.0 rc1 ngModel nonassign error in ngCsp mode #9048

graynote opened this issue Sep 12, 2014 · 4 comments
Labels
component: forms component: $parse severity: regression type: bug
Milestone
1.3.0-rc.2

Comments

@graynote
Copy link

I only added ng-csp in html tag in ngModel example code.

http://plnkr.co/edit/wyi8mTlY2NpF6QLbPWYL

It raises nonassign error.
@Narretz
Copy link
Contributor

Narretz commented Sep 12, 2014

Could be because of 9ad7d74 /cc @tbosch

@Narretz Narretz added this to the 1.3.0-rc.2 milestone Sep 12, 2014
@caitp
Copy link
Contributor

caitp commented Sep 12, 2014

No, I'm pretty sure it's b3b476d --- we're apparently not setting up assign() for CSP mode --- oops!

@caitp
Copy link
Contributor

caitp commented Sep 12, 2014

I'll see if I can write up a patch quickly

@caitp
Copy link
Contributor

caitp commented Sep 12, 2014

I am also pretty sure our test suite for CSP parsing is broken because we aren't correctly setting up csp mode :<

caitp added a commit to caitp/angular.js that referenced this issue Sep 12, 2014
@caitp
fix($parse): add .assign() function to settable expressions in CSP …
3c1e47b 
…mode

Due to changes to CSP-mode detection and the CSP api in general, the test suite was not able to
report regressions related to CSP.

This CL corrects the broken test suite and broken CSP detection mechanics in $parse, and corrects
the regression introduced where assignable expressions would not have an `assign` routine in CSP
mode.

Closes angular#9048
caitp added a commit to caitp/angular.js that referenced this issue Sep 12, 2014
@caitp
fix($parse): add .assign() function to settable expressions in CSP …
192a0b8 
…mode

Due to changes to CSP-mode detection and the CSP api in general, the test suite was not able to
report regressions related to CSP.

This CL corrects the broken test suite and broken CSP detection mechanics in $parse, and corrects
the regression introduced where assignable expressions would not have an `assign` routine in CSP
mode.

Closes angular#9048
caitp added a commit to caitp/angular.js that referenced this issue Sep 12, 2014
@caitp
fix($parse): add .assign() function to settable expressions in CSP …
64112e1 
…mode

Due to changes to CSP-mode detection and the CSP api in general, the test suite was not able to
report regressions related to CSP.

This CL corrects the broken test suite and broken CSP detection mechanics in $parse, and corrects
the regression introduced where assignable expressions would not have an `assign` routine in CSP
mode.

Closes angular#9048
This was referenced Sep 12, 2014
Closed
Closed
caitp added a commit to caitp/angular.js that referenced this issue Sep 12, 2014
@caitp
fix($parse): ensure CSP assignable expressions have assign()
f2f390d 
Fixes regression where the `assign()` method was not added to chains of identifiers in CSP mode,
introduced originally in b3b476d.

Closes angular#9048
@caitp caitp closed this as completed in d13b4bd Sep 12, 2014
@caitp caitp mentioned this issue Sep 12, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: forms component: $parse severity: regression type: bug
Projects
None yet
Milestone
1.3.0-rc.2
Development

Successfully merging a pull request may close this issue.

fix($parse): add .assign() function to settable expressions in CSP mode caitp/angular.js
3 participants
@Narretz @caitp @graynote