-
Notifications
You must be signed in to change notification settings - Fork 27.4k
What changes could have affected ui-mask? #9138
Comments
need to investigate it further, on plunkr, without no other directives on the input, it works I'm trying to reproduce the problem I'm facing after updating angular |
this plunker works fine for me... can you explain how to reproduce the issue? |
yes, I'm trying to recreate part of my app (that's kinda huge). right now it works on plunkr but doesn't on my app I'm wild guessing this is the problem 3e51b84#diff-c244afd8def7f268b16ee91a0341c4b2R1003 the logic changed I'm re$compiling the same input over and over, mixed with transclusion, by different directives that add helper directives to elements, I just can't seem to find where it's choking, because it just worked before |
I'm really frustated that I can't reproduce yet, and I couldn't make it work on my own app yet... removing each directive from my inputs, it seems to be the one that I put in the plunkr (cleanMask / cleanViewValue), but on the plunkr it works, and not in my code EDIT: ok, lastest plunkr version have one of the problems.
from what I can see in the DOM data view, the field when entered has a EDIT2: Although reviewing the migration guide from Angular, the post link is from low to high. Maybe that's something to do and transcluded inputs needs a different approach, but this same code used to work on beta 19 (besides the |
I ran a git bisect. The commit which caused the bug is 3e51b84 |
@pocesar I saw you have opened a PR in angular-ui to update ui-mask to 1.3.x. Does that mean we can close this issue? |
I'm cross posting to angular-ui/ui-utils#294 because I need this working. I'm trying to fix it myself, and couldn't find what changes from beta.19 to rc0+ that broke it
When I type the cursor moves erroneously and the characters are input in wrong order. Plus, if the field has
updateOn: 'default blue', debounce: {default: 700}
, if I don't type fast enough, it clears the input, erasing everything I wroteThe text was updated successfully, but these errors were encountered: