SCOPE DESTRUCTION: Directive scope is never destroyed if immediately switched out and it has templateUrl. #9197

applegrew · 2014-09-21T04:39:10Z

We have a directive which uses templateUrl that is rendered within a ngSwitch. There is a scenario where on page load the directive is rendered, but then immediately some conditions change causing ngSwitch to remove the directive from page. I found that in that case the directive's scope never gets destroyed.

A Plunker demo is available here - http://plnkr.co/edit/QYnUKQrHA4uivJifsYne?p=preview

In the demo open browser's JS console. Notice that you will only see '>>>Created' message, but no '>>>Destroyed'. This bug happens only when the directive uses templateUrl. If you change the above demo code to use template instead then notice the bug is gone.

The html snippet is:-

<body ng-controller="Main">
<div>
  <div ng-switch="code">
    <div ng-switch-when="red">
      <red></red>
    </div>
  </div>
</div>
</body>

The controller code is:-

controller('Main', function ($scope, $timeout) {
  $scope.code = 'red';
  $timeout(function () {
    $scope.code = 'blue';
  })
})

So as soon as the controller loads, $scope.code is set to 'blue' in next digest cycle, causing the directive red to appear momentarily.

The directive code is:-

directive('red', function () {
  return {
    restrict: 'E',
    replace: true,
    templateUrl: 'red.html',
    scope: {},
    link: function (scope) {
      console.log('>>>Created');
      scope.$on('$destroy', function (event) {
        console.log('>>>Destroyed');
      })
    }
  };
})

If I use template instead of templateUrl, then $destroy is called. The replace: true or isolated scope are not necessary to replicate this bug.

The text was updated successfully, but these errors were encountered:

lgalfaso · 2014-09-21T07:31:19Z

The issue is that the scope that the directive gets is already destroyed, in fact, it is already removed from the hierarchy

lgalfaso · 2014-09-21T07:31:48Z

Let me take a deeper look into this issue

lgalfaso · 2014-09-21T08:43:44Z

it looks like this is a bigger issue than expected

caitp · 2014-09-24T01:14:44Z

@petebacondarwin assigning this to you since it's basically the same as lucas' dupe (lets just close it when we land the fix)

Stop an asynchronous compilation when this is performed on an already destroyed scope Closes angular#9199 Closes angular#9079 Closes angular#8504 Closes angular#9197

Stop an asynchronous compilation when this is performed on an already destroyed scope Closes #9199 Closes #9079 Closes #8504 Closes #9197

tiff · 2014-10-05T22:13:12Z

The Changelog says that this also made it into v1.2.26. I just downloaded it from angularjs.org and didn't find this change in it...

Edit: Probably because of this commit

cztomsik · 2014-10-21T15:13:20Z

+1

lgalfaso mentioned this issue Sep 21, 2014

SCOPE DESTRUCTION: Leak when asynchronously continuing the linking of directives on scopes that are already destroyed #9199

Closed

caitp added this to the 1.3.0-rc.4 milestone Sep 24, 2014

caitp added the severity: memory leak label Sep 24, 2014

caitp assigned petebacondarwin Sep 24, 2014

petebacondarwin changed the title ~~Directive scope is never destroyed if immediately switched out and it has templateUrl.~~ SCOPE DESTRUCTION: Directive scope is never destroyed if immediately switched out and it has templateUrl. Sep 26, 2014

lgalfaso closed this as completed in 6303c3d Sep 29, 2014

petebacondarwin mentioned this issue Sep 29, 2014

fix($compile): Resolve various potential memory leaks (v1.2.x) #9326

Closed

petebacondarwin added a commit that referenced this issue Sep 29, 2014

fix($compile): Resolve leak with asynchronous compilation

5c9c197

Stop an asynchronous compilation when this is performed on an already destroyed scope Closes #9199 Closes #9079 Closes #8504 Closes #9197

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SCOPE DESTRUCTION: Directive scope is never destroyed if immediately switched out and it has templateUrl. #9197

SCOPE DESTRUCTION: Directive scope is never destroyed if immediately switched out and it has templateUrl. #9197

applegrew commented Sep 21, 2014

lgalfaso commented Sep 21, 2014

lgalfaso commented Sep 21, 2014

lgalfaso commented Sep 21, 2014

caitp commented Sep 24, 2014

tiff commented Oct 5, 2014

cztomsik commented Oct 21, 2014

SCOPE DESTRUCTION: Directive scope is never destroyed if immediately switched out and it has templateUrl. #9197

SCOPE DESTRUCTION: Directive scope is never destroyed if immediately switched out and it has templateUrl. #9197

Comments

applegrew commented Sep 21, 2014

lgalfaso commented Sep 21, 2014

lgalfaso commented Sep 21, 2014

lgalfaso commented Sep 21, 2014

caitp commented Sep 24, 2014

tiff commented Oct 5, 2014

cztomsik commented Oct 21, 2014