Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

require on directives should pass null when the controller is not found and is optional #9404

Closed
kentcdodds opened this issue Oct 2, 2014 · 7 comments

Comments

@kentcdodds
Copy link
Member

Currently it's passing undefined when it should pass null. Identified in #9392.

I'm working on updating the #9392 PR to include this fix.

@caitp
Copy link
Contributor

caitp commented Oct 2, 2014

I don't know if a new issue is needed for this, I'm not sure if anyone even agrees with me that not being null is a bug --- I think it would be better, but who knows

@kentcdodds
Copy link
Member Author

Yeah, I like the idea of commits being related to an issue, that's why I created the issue in the first place.

@btford
Copy link
Contributor

btford commented Oct 7, 2014

null seems a bit better, but I don't think that there's a strong enough argument to warrant changing the behavior :/

@btford btford added this to the Backlog milestone Oct 7, 2014
@kentcdodds
Copy link
Member Author

Understood. It's definitely a breaking change, although it's much smaller than many others going into 1.3...

@caitp
Copy link
Contributor

caitp commented Oct 8, 2014

I'm pro-changing it, since we explicitly set it to null in the non-array case. It's good to be consistent

@caitp
Copy link
Contributor

caitp commented Oct 8, 2014

And as for it being a breaking change, I don't think anyone is realistically depending on it being undefined

@kentcdodds
Copy link
Member Author

@caitp, I concur with that analysis of the breaking-ness of this change :-)

@caitp caitp closed this as completed in 2cd5b4e Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants