Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

jqLiteOff doesn't remove event handler from DOM correcly, which affects Safari on iOS #9509

Closed
Peng-Peng opened this issue Oct 9, 2014 · 0 comments
Closed

jqLiteOff doesn't remove event handler from DOM correcly, which affects Safari on iOS #9509

Peng-Peng opened this issue Oct 9, 2014 · 0 comments
Assignees
@IgorMinar
Labels
component: jqLite frequency: low severity: broken expected use type: bug
Milestone
1.3.0-rc.6

Comments

@Peng-Peng
Copy link

https://github.com/angular/angular.js/blob/master/src/jqLite.js#L287
jqLiteOff doesn't remove registered event listener from DOM, this affects the behavior of element in Safari on iOS as some event bubbling in Safari depends on whether an element has mouse event handler or not. Please refer to http://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html
@Peng-Peng Peng-Peng changed the title jqLiteOff doesn't remove event handler from DOM correcly jqLiteOff doesn't remove event handler from DOM correcly, which affects Safari on iOS Oct 9, 2014
@jeffbcross jeffbcross added this to the Backlog milestone Oct 9, 2014
@IgorMinar IgorMinar self-assigned this Oct 10, 2014
IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Oct 10, 2014
@IgorMinar
eix(jqLite): remove native listener when all jqLite listeners were de…
be26eb6 
…registered

This fixes an iOS issue where some events buble only when native listeners are present (see angular#9509),
but more importantly previously we would pass wrong argument into the `removeEventListenerFn`  which
caused native listeners to be never deregistered. Oops!

Closes angular#9509
@IgorMinar IgorMinar mentioned this issue Oct 10, 2014
Closed
IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Oct 10, 2014
@IgorMinar
fix(jqLite): remove native listener when all jqLite listeners were de…
babf2a4 
…registered

This fixes an iOS issue where some events buble only when native listeners are present (see angular#9509),
but more importantly previously we would pass wrong argument into the `removeEventListenerFn`  which
caused native listeners to be never deregistered. Oops!

Closes angular#9509
@IgorMinar IgorMinar modified the milestones: 1.3.0-rc.6, Backlog Oct 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@IgorMinar IgorMinar

Labels
component: jqLite frequency: low severity: broken expected use type: bug
Projects
None yet
Milestone
1.3.0-rc.6
Development

Successfully merging a pull request may close this issue.

fix(jqLite): remove native listener when all jqLite listeners were deregistered IgorMinar/angular.js
3 participants
@IgorMinar @jeffbcross @Peng-Peng