Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

setup for e2e tests outside of docs #9527

Closed
tbosch opened this issue Oct 9, 2014 · 3 comments
Closed

setup for e2e tests outside of docs #9527

tbosch opened this issue Oct 9, 2014 · 3 comments
Assignees
@caitp
Labels
type: chore
Milestone
1.3.1

Comments

@tbosch
Copy link
Contributor

tbosch commented Oct 9, 2014

Hi,
right now we sometimes misuse our docs to create examples for edge cases so that we can have e2e tests for those cases, instead of creating very simple examples and testing those.

Let's change our setup so that we can create e2e tests outside of the docs. Here is a first proposal:

Folder structure:

e2e_tests
  templates
    header_jquery.html
    header_jqlite.html
  fixtures
    myFixture.html
    myFixtures.js
  tests
    myTest.js

The header_jquery.html resp header_jqlite.html would contain the following:

<html>
<head>
  <script src="<path to jquery.js resp jqlite.js>"></script>
  <script src="<path to angular.js>"></script>
</head>
</body>

We would configure our http server to serve a url like http://localhost:8000/e2e/myTest.html?jquery as follows:

  • header_jquery.html
  • + <script src="myTest.js"></script> (via naming convention)
  • + myTest.html
  • + </body></html>

When we run the tests via protractor we set a configuration variable env to either jquery or jqlite and provide a helper function that returns the url for the html file given the __filename of the e2e test using a naming convention.
E.g. within myTest.js:

beforeEach(function() {
  browser.get(fixtureFor(__filename)); // -> would result in `http://localhost:8000/e2e/myTest.html?jquery`
});
...

A first good candidate for this would be the e2e test for ngCsp.

@petebacondarwin @caitp What do you think?
/cc @IgorMinar
@tbosch tbosch added this to the Backlog milestone Oct 9, 2014
@caitp
Copy link
Contributor

caitp commented Oct 9, 2014

I like the idea.

Sent from my iPhone

On Oct 9, 2014, at 3:02 PM, Tobias Bosch notifications@github.com wrote:

Hi,
right now we sometimes misuse our docs to create examples for edge cases so that we can have e2e tests for those cases, instead of creating very simple examples and testing those.

Let's change our setup so that we can create e2e tests outside of the docs. Here is a first proposal:

Folder structure:

e2e_tests
templates
header_jquery.html
header_jqlite.html
fixtures
myFixture.html
myFixtures.js
tests
myTest.js
The header_jquery.html resp header_jqlite.html would contain the following:

<script src=""></script> <script src=""></script> We would configure our http server to serve a url like http://localhost:8000/e2e/myTest.html?jquery as follows:

header_jquery.html

  • <script src="myTest.js"></script> (via naming convention)
  • myTest.html
  • When we run the tests via protractor we set a configuration variable env to either jquery or jqlite and provide a helper function that returns the url for the html file given the __filename of the e2e test using a naming convention. E.g. within myTest.js:

beforeEach(function() {
browser.get(fixtureFor(__filename)); // -> would result in http://localhost:8000/e2e/myTest.html?jquery
});
...
A first good candidate for this would be the e2e test for ngCsp.

@petebacondarwin @caitp What do you think?
/cc @IgorMinar

—
Reply to this email directly or view it on GitHub.

@IgorMinar
Copy link
Contributor

@caitp can you own this?

This was referenced Oct 10, 2014
Merged
Closed
@IgorMinar IgorMinar mentioned this issue Oct 10, 2014
Closed
@IgorMinar
Copy link
Contributor

I'm labeling this with post-1.3.0 but it's ok to land it early :)

@tbosch tbosch mentioned this issue Oct 13, 2014
Closed
@caitp caitp mentioned this issue Oct 15, 2014
Closed
@tbosch tbosch modified the milestones: Backlog, 1.3.1 Oct 15, 2014
@caitp caitp closed this as completed in 2240c11 Oct 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caitp caitp

Labels
type: chore
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
3 participants
@IgorMinar @tbosch @caitp