Angular mocks .module() and .inject() interaction changed in 1.3.0

[stephenhand]

In angular 1.2.x, any dependencies you mocked out using $provide were only mocked out when accessed from the module under test, but when mocks.inject was called, any injected dependencies were still built using the real implementations of their subdependencies.

In 1.3.0, once the module has mocked out the dependency, this mock is then substituted when required to construct injected dependencies in an inject call.

For example, take the following test setup:

    var mockWindow, compile;
    beforeEach(function () {
        mockWindow = {
            addEventListener:mockFunction(),
            removeEventListener:mockFunction()
        };
        mocks.module('rcom.columnEditor', function($provide){
            $provide.value('$window', mockWindow);
        });
        mocks.inject(function ($document, $rootScope, $compile) {
            compile = $compile;
        });
    });

In angular 1.2.x this was fine, because, although $compile eventually depends on $window to give it a document object, it used the 'real' window, which gave it a real document.

In angular 1.3.0, this does not work, because mockWindow is used when $window is required by $document, and mockWindow does not define a document object. Therefore $document is an empty jqLite object which causes errors in $sce.

Is this a deliberate change? I can kinda see the logic to both ways but the 1.2.x method seems more practically useful. I can see lots of weird and difficult to track down issues being caused by the 1.3.0 behaviour and very little practical use for injecting objects built on mocks (if you need mock behaviour in a dependency, surely just mock it out at the top level object using $provide and not inject it at all?)

Thanks for any clarification!

[gkalpak]

The problem with $sce was that it used to use $document to detect the IE version. This has been fixed in #9663.

So, if your tests do not rely on document you'll be fine.
If they do need document, you can provide a mocked window object with a document property.

[stephenhand]

Ok, thanks for the prompt response. It's fairly straightforward to work around in our current tests until we upgrade to 1.3.1 so that's fine for me.