ngRoute interpolate route with optional parameters

[urffin]

if we have route path like
/:lang/:paramone?/:paramtwo?

then interpolate function
for params = { lang:'en', paramone:'one', paramtwo:'two' }
return next wrong url
/en/one?/two?/

because in this code

var segmentMatch = segment.match(/(\w+)(.*)/); //possibly wrong regexp
var key = segmentMatch[1];
result.push(params[key]);
result.push(segmentMatch[2] || '');

for paramone we have:

segment = 'paramone?'
segmentMatch = ["paramone?/", "paramone", "?/"]
key = "paramone"
result.push(segmentMatch[2] || ''); // push '?/' !!!

[gkalpak]

Can't reproduce on 1.3.0 (fiddle).
The docs seem quite outdated though :(

[urffin]

i little update your fiddle
see value when set all optional params
like this #/param1/param2/param3/

[gkalpak]

I see. So the trailing / messes optional params.
This seems like a valid bug.

[gkalpak]

@urffin: Indeed fixing the RegExp on https://github.com/angular/angular.js/blob/master/src/ngRoute/route.js#L637 did it (#9827).

[Narretz]

Duplicate of #9742?

[gkalpak]

Uh oh ! There seems to be a whole "ecosystem" (of issues and PRs) around this bug.

I guess I know the drill (#9788) 😃

[Narretz]

I think it's not that bad ;)

[gkalpak]

Indeed, it wasn't that bad 😃

---

Issues:

• $routeProvider - optional named group + trailing slash  #9742: Is the same issue as this one (actually it is the other way around).
• ngRoute interpolate route with optional parameters #9819: Is a duplicate of $routeProvider - optional named group + trailing slash  #9742.

(All three PRs mentioned below, address these issues.)

---

PRs:

• fix(ngRoute): wrong redirect to paths containing optional or special parameters #5746, fix($route): fix redirection with optional/eager params #9827:
  Both fix the curently reported issue (but do not address the corner-case mentioned in improve interpolation of params in ngRoute #8200).
  Additionally, fix($route): fix redirection with optional/eager params #9827 contains a test we might want to keep (and some unrelated test-name fixes).
• improve interpolation of params in ngRoute #8200:
  Fixes the currently reported issue and also a corner-case (not addressed by the other two PRs).
  I like the approach in improve interpolation of params in ngRoute #8200 better (not only because it fixes more issues); I find it more clear/straightforward.
  I am not sure it covers the fix with tests properly though.

---

My suggestion:

1. Merge the test-name fixes and the test case from fix($route): fix redirection with optional/eager params #9827.
2. Merge improve interpolation of params in ngRoute #8200.
3. Close the PRs: fix(ngRoute): wrong redirect to paths containing optional or special parameters #5746, improve interpolation of params in ngRoute #8200, fix($route): fix redirection with optional/eager params #9827
4. Close the issues: $routeProvider - optional named group + trailing slash  #9742, ngRoute interpolate route with optional parameters #9819

_{(Needless to say, if you decide to keep the test-related changes from #9827, I will update the PR with just those changes.)}

[Narretz]

Thanks again @gkalpak for the detailed summary. Looks like #8200 still needs a little work