ngIf with replace:true on directive template

[bertrandgressier]

Hello team,

We have a regression with the last angular version (since v1.3.0-beta.11)

In this commit d71df9f#diff-1c8fbee1402a2ef3c203def41d1960cdR97, you modified the child scope ngIf uses. Now with this modification, using ngIf on the root element of a directive template that is configured with replace:true, the $scope is not the expected one. (it's not the same)

We tried to build a reduced test case to show the regression :

• 1.3.0-beta 10 : http://jsbin.com/sakuto/9/edit
• 1.3.0-beta 11 : http://jsbin.com/yubetu/1/edit

As you can see, the first directive failed in beta 11.

What do you think ? Is it a bug or the new expected behaviour ?
If so, maybe we should detail the documentation.

thx!

[clakech]

Hi, @caitp could you help us on this one? ;-)

[caitp]

since you asked nicely ^^

[caitp]

so, you can work around this by not using an element transclusion directive as the root element of the template --- I'm not sure exactly why this worked in beta 10 though, doesn't make a lot of sense.

Lets dig through the changelog and see if it's listed in any of the breaking changes

[caitp]

@petebacondarwin there are no breaking changes for $compile in beta 11, i think we forgot to add them

[caitp]

I wonder if we could make this more palatable --- like, if you have element transclusion at the root of a replacement template, it should add the original parent scope in a custom data field, and use that when getting the parent scope.

[clakech]

Thank you for your help about this! I knew your advice would be useful! ^^

We would definitely love to see a breaking change in the changelog and a new palatable behavior of angular in this use case.

We hesitate between removing replace:true and avoid using element transclusion directive as root element.

[clakech]

Ok so I added another exemple in the jsbin with a use case where the ng-if is not on the root element of the directive:

http://jsbin.com/fahoz/1/edit?html,js,output

[pocesar]

seeing this as well, since upgrading to 1.3.1. my template is

template =  '<div class="tab-content" ng-if="visible">' +
                    '<div ng-if="tab" class="tab-inner-content clearfix" ng-include="tab"></div>' +
                   '</div>';

and it broke

[clakech]

OK so someone need to propose a breaking change for this but where should we document this ? in ngIf doc ? in directive doc ? in changelog ?