Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

scope.$eval with "" (empty string) keys #9893

Closed
taylor1791 opened this issue Nov 3, 2014 · 2 comments
Closed

scope.$eval with "" (empty string) keys #9893

taylor1791 opened this issue Nov 3, 2014 · 2 comments
Labels
component: $parse frequency: low severity: broken expected use type: bug
Milestone
Backlog - won't fix

Comments

@taylor1791
Copy link

scope.$eval('{"":"test"}') and JSON.parse('{"":"test"}') should produce the same result.

See
https://gist.github.com/anonymous/0dc24d0c8948c75b4086
http://jsbin.com/gafule/1/edit
@lgalfaso lgalfaso self-assigned this Nov 4, 2014
@lgalfaso
Copy link
Contributor

lgalfaso commented Nov 4, 2014

looks like a real bug, should be an easy fix and will post a PR in a few

lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Nov 4, 2014
@lgalfaso
fix($parse): Handle the empty string as an object key
0d0df08 
When rebuilding an object literal key, use `isDefined` to decide if
this is a string token or an identifier

Closes angular#9893
@lgalfaso lgalfaso mentioned this issue Nov 4, 2014
Closed
Closed
@lgalfaso lgalfaso removed their assignment Nov 5, 2014
@pkozlowski-opensource pkozlowski-opensource added this to the Backlog milestone Nov 6, 2014
@pkozlowski-opensource
Copy link
Member

This was fixed in master via fbad280:
http://jsbin.com/zasaqitani/2/edit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: $parse frequency: low severity: broken expected use type: bug
Projects
None yet
Milestone
Backlog - won't fix
3 participants
@lgalfaso @taylor1791 @pkozlowski-opensource