This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Cleanup handling of bind-once delegates after #9825 #9958

Closed

caitp opened this issue Nov 7, 2014 · 0 comments

Assignees

Labels

component: $compile component: $parse frequency: moderate severity: confusing type: bug

Milestone

Contributor

caitp commented Nov 7, 2014

As noted in #9825 / ed99821, we are doing some weird things, and now treating certain expressions as "stateful" in a way that doesn't really make sense.

Watch delegates shouldn't be stateful unless they absolutely need to be (IE depend on a stateful filter) --- and we shouldn't be performing the bind-once behaviour unless we're actually trying to bind-once.

The text was updated successfully, but these errors were encountered:

caitp added type: bug component: $parse component: $compile labels

caitp self-assigned this

caitp added frequency: moderate severity: confusing labels

caitp modified the milestones: 1.3.x, 1.3.3

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

c8c60e2

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Closes angular#9958

caitp mentioned this issue

refactor($parse): don't use bind-once interceptor for non-bind-once expressions #9961

Closed

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

773ee2d

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

83ce6aa

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

df8813c

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Credit to @jbedard for idea to remove $watch interceptors craziness from $interpolate.

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

fa2ec06

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Credit to @jbedard for idea to remove $watch interceptors craziness from $interpolate.

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

93ac49f

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Credit to @jbedard for idea to remove $watch interceptors craziness from $interpolate.

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

b062fb3

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Credit to @jbedard for idea to remove $watch interceptors craziness from $interpolate.

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

3c74c3a

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Credit to @jbedard for idea to remove $watch interceptors craziness from $interpolate.

Closes angular#9958

caitp added a commit to caitp/angular.js that referenced this issue


          refactor($parse): don't use bind-once interceptor for non-bind-once e…

b06c581

…xpressions

Side-effects:
  - Logic for allOrNothing watches now lives in $intercept rather than $parse

Credit to @jbedard for idea to remove $watch interceptors craziness from $interpolate.

Closes angular#9958

caitp closed this as completed in

b7afd11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.