Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

createBoundTranscludeFn still has unused elementTransclusion argument #9962

Closed
OpenSiteMobile opened this issue Nov 7, 2014 · 0 comments
Closed

Comments

@OpenSiteMobile
Copy link

I've been looking at AngularJS version 1.3.1 versus 1.3.0.rc1 and found this inconsistency.

The "createBoundTranscludeFn" function, defined under $get of the "$CompileProvider" function has a fourth argument (elementTransclusion) which is no longer used in version 1.3.1. However, this code:

        if (nodeLinkFn.transcludeOnThisElement) {
          childBoundTranscludeFn = createBoundTranscludeFn(
              scope, nodeLinkFn.transclude, parentBoundTranscludeFn,
              nodeLinkFn.elementTranscludeOnThisElement);

...in the "compositeLinkFn" function (at line 6945 of v1.3.1) is still passing that forth argument. Since it was used in version 1.3.0rc1, but that reference is gone in version 1.3.1, I assume the fourth argument is no longer being used. Just wanted to make sure that is what was intended as the final change.

@Narretz Narretz added this to the Backlog milestone Nov 9, 2014
teropa added a commit to teropa/angular.js that referenced this issue May 30, 2015
Remove the unused elementTransclusion argument from createBoundTranscludeFn.
Also remove the nodeLinkFn.elementTranscludeOnThisElement attribute, which
becomes unnecessary.

Closes angular#9962
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
Remove the unused elementTransclusion argument from createBoundTranscludeFn.
Also remove the nodeLinkFn.elementTranscludeOnThisElement attribute, which
becomes unnecessary.

Closes angular#9962
Closes angular#11985
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants