You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
I've been looking at AngularJS version 1.3.1 versus 1.3.0.rc1 and found this inconsistency.
The "createBoundTranscludeFn" function, defined under $get of the "$CompileProvider" function has a fourth argument (elementTransclusion) which is no longer used in version 1.3.1. However, this code:
if (nodeLinkFn.transcludeOnThisElement) {
childBoundTranscludeFn = createBoundTranscludeFn(
scope, nodeLinkFn.transclude, parentBoundTranscludeFn,
nodeLinkFn.elementTranscludeOnThisElement);
...in the "compositeLinkFn" function (at line 6945 of v1.3.1) is still passing that forth argument. Since it was used in version 1.3.0rc1, but that reference is gone in version 1.3.1, I assume the fourth argument is no longer being used. Just wanted to make sure that is what was intended as the final change.
The text was updated successfully, but these errors were encountered:
Remove the unused elementTransclusion argument from createBoundTranscludeFn.
Also remove the nodeLinkFn.elementTranscludeOnThisElement attribute, which
becomes unnecessary.
Closesangular#9962
Remove the unused elementTransclusion argument from createBoundTranscludeFn.
Also remove the nodeLinkFn.elementTranscludeOnThisElement attribute, which
becomes unnecessary.
Closesangular#9962Closesangular#11985
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I've been looking at AngularJS version 1.3.1 versus 1.3.0.rc1 and found this inconsistency.
The "createBoundTranscludeFn" function, defined under $get of the "$CompileProvider" function has a fourth argument (elementTransclusion) which is no longer used in version 1.3.1. However, this code:
...in the "compositeLinkFn" function (at line 6945 of v1.3.1) is still passing that forth argument. Since it was used in version 1.3.0rc1, but that reference is gone in version 1.3.1, I assume the fourth argument is no longer being used. Just wanted to make sure that is what was intended as the final change.
The text was updated successfully, but these errors were encountered: