This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMock): call $interval callbacks even when invokeApply is false #10032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions given to ngMock's $interval aren't being called after $interval.flush(...) when invokeApply is false. This is because $q.notify does work inside nextTick, and the nextTick provided to $q (which is $rootScope.$evalAsync), doesn't tick until a digest.
I mostly took changes from 19b6b34
I'm not really happy with the fix, but I don't know if it's actually a problem. It would be nice if ngMock's $interval was a decorator like $timeout, but I think that's too much of a change for my first PR.
edit: forgot a word, I'm not happy with the fix