This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($locale): Allow currency filter to fall back to maxFrac from locale #10179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
| @@ -120,6 +120,14 @@ describe('filters', function() { | |||
| expect(currency(0.008)).toBe('$0.01'); | |||
| expect(currency(0.003)).toBe('$0.00'); | |||
| }); | |||
|
|
|||
| it('should set the default fraction size to the max fraction size of the locale value', inject(function($locale) { | |||
| $locale.NUMBER_FORMATS.PATTERNS[1].maxFrac = 1; | |||
There was a problem hiding this comment.
can you either use jasmine's mocking library or create a $locale mock for this test instead of trying to reset the value at the end of the test?
reason: if the expectations fail the state won't be restored and that will make all the subsequent tests fail and it will be hard to find the cause.
|
let's reclasify this to a fix. I think there is an open issue or maybe even prs for this, but they were all incorrect, so if you could find the dupes that would be awesome |
- Modify default fallback to `NUMBER_FORMATS.PATTERNS[1].maxFrac` - Remove unnecessary resetting
wesleycho
force-pushed
the
feat/locale_fraction_size
branch
from
550f64c to
ec09be6
Compare
wesleycho
changed the title
|
Implemented fix. This does not look like it addresses any other open issues that I can find. |
gkalpak
pushed a commit
to gkalpak/angular.js
that referenced
this pull request
Dec 5, 2014
- Modify default fallback to `NUMBER_FORMATS.PATTERNS[1].maxFrac` - Remove unnecessary resetting Closes angular#10179
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUMBER_FORMATS.PATTERNS[1].maxFracNote that the default value currently is 2, so it preserves the existing behavior.