This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($compile): Add support for ng-attr with camelcased attributes #10194
+49
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
wesleycho
force-pushed
the
feat/svg-camelcase
branch
8 times, most recently
from
4c65130 to
53a46ab
Compare
| @@ -1405,7 +1405,10 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { | |||
| // support ngAttr attribute binding | |||
| ngAttrName = directiveNormalize(name); | |||
| if (isNgAttr = NG_ATTR_BINDING.test(ngAttrName)) { | |||
| name = snake_case(ngAttrName.substr(6), '-'); | |||
| name = name.replace(/^(data|x)-/, '') | |||
There was a problem hiding this comment.
You are ignoring other valid separators (:, _). There is a RegExp for that (PREFIX_REGEXP).
wesleycho
force-pushed
the
feat/svg-camelcase
branch
from
53a46ab to
d122143
Compare
wesleycho
force-pushed
the
feat/svg-camelcase
branch
from
d122143 to
beecf2e
Compare
- Modify $compile to handle camelcased attributes only with ng-attr to support SVG fully - Change to svg to make clear it works - Ensure the elements and attributes used are valid SVG elements & attributes - Modify in attempt to use attribute IE is happy with - Add specific SVG check for IE - Fix incorrect attribute value used Modification to re-run tests - Break up line for jshint - Fix codestyle - Replace with prefix regexp - Added more test cases to catch prefix regexp - Add documentation in the guide on using underscores
wesleycho
force-pushed
the
feat/svg-camelcase
branch
from
beecf2e to
d16d403
Compare
petebacondarwin
pushed a commit
that referenced
this pull request
Dec 9, 2014
SVG attributes are case sensitive and some have upper case letters in them This change ensures that we can identify these, when being used with the `ng-attr` directive, by encoding upper case letters with a preceding underscore. For example to apply `ng-attr` to the `viewBox` attribute we could write `ng-attr-view_box` - or any of the other variants: `ng:attr:view_box`, `data-ng-attr-view_box`, etc. Closes #9845 Closes #10194
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support SVG fully
This should address #9845.