docs(select): Updated ngOptions track by examples #10224
Conversation
Made the example shown consistent with the advice above it regarding not using `select as` and `track by` in the same comprehension expression. Also changed references to `trackexpr` to `track by` since `trackexpr` is not defined except in the examples.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
Signed the CLA |
|
CLAs look good, thanks! |
The documentation for ngRepeat includes such an example specifying the proper order for filters and and "track by" clauses in the comprehension expression, but these docs for ngOptions do not.
|
Addresses confusion in #10225 |
|
Hi @WatchSteveDrum, thanks for the PR. Can you please squash the two commits into one? |
|
landed as b9e5eaf |
Made the example shown consistent with the advice above it regarding not using
select asandtrack byin the same comprehension expression. Also changed references totrackexprtotrack bysincetrackexpris not defined except in the examples.