Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngMock): annotate $RootScopeDecorator #10275

Closed
wants to merge 2 commits into from
Closed

fix(ngMock): annotate $RootScopeDecorator #10275

wants to merge 2 commits into from

Conversation

shahata
Copy link
Contributor

@shahata shahata commented Nov 30, 2014

Closes #10273

@googlebot
Copy link

CLAs look good, thanks!

@pkozlowski-opensource
Copy link
Member

@shahata would be there a way of testing it somehow?

@shahata
Copy link
Contributor Author

shahata commented Nov 30, 2014

@pkozlowski-opensource - I'm looking into it, see my comments in the original issue.

@shahata
Copy link
Contributor Author

shahata commented Nov 30, 2014

@pkozlowski-opensource @caitp - I've added another commit to this PR with a simple mechanism that cleans up $inject from functions that were annotated during each test. This will help detect future problems in angular and also in apps that use strictDi only in part of their tests. WDYT?

this will help in detecting unannotated functions both in apps and angular core in case only part of the tests are run with strictDi
@shahata shahata closed this in 9a83f9d Dec 1, 2014
@shahata
Copy link
Contributor Author

shahata commented Dec 1, 2014

So we don't want the $inject cleanup thing?

@pkozlowski-opensource
Copy link
Member

@shahata not in 1.3.5. Could you please open a separate PR with it?

@caitp
Copy link
Contributor

caitp commented Dec 1, 2014

@pkozlowski-opensource what he means is "we don't want to use $inject everywhere rather than the array notation?" --- I said I preferred it, because it's a lot easier to read and see what's going on, but honestly I really don't care, it doesn't matter that much.

@shahata
Copy link
Contributor Author

shahata commented Dec 2, 2014

Actually @pkozlowski-opensource understood me correctly. I'll open a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular-mocks strictDi mode doesn't work because of missing annotation on $RootScopeDecorator
4 participants