refactor(ngAria): DRY camelcase method

[cironunes]

@petebacondarwin I'm using attr.$normalize as you suggested in #10337 (comment)

The problem is that we also need to normalize the name in the service. Probably that's why the local camelCase method was created in the first place.

I still think that we should have a public camelcaseas we do with lowercase and uppercase, but I'm not sure how to better approach this, what do you think?

[googlebot]

CLAs look good, thanks!

[petebacondarwin]

That is also a bug in ngAria. They should not be handling non-canonical attribute names in $ariaProvider.config at https://github.com/angular/angular.js/blob/master/src/ngAria/aria.js#L181.

And in any case if they were then they should be using the directiveNormalize version.

Instead, they should require that this param is already normalized. In the code the only place this happens in ngAria is inside shouldAttachAttr, which should also always be called with a normalized attribute.

Some cases are already covered (hard-coded strings) except for at line 244, line 265, line 275, line 283.

[petebacondarwin]

We want to limit the public API to "helper" methods since this adds to the size of the core file and the maintenance effort. Many of the angular.xxx methods should not have been public in the first place :-)

[cironunes]

@petebacondarwin I updated the PR with the changes. Now the local camelCase can be removed. :)

[cironunes]

I understand, thanks for the patience to explain.

[petebacondarwin]

Thanks!!