This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(compile): document $attrs.$normalize #10345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
Closed
| * | ||
| * Also there is special case for Moz prefix starting with upper case letter. | ||
| * | ||
| * @param name Name to normalize |
There was a problem hiding this comment.
Having the type here as well would be nice.
There was a problem hiding this comment.
Good catch! You got it.
cironunes
force-pushed
the
docs-normalize
branch
from
11ca1a9 to
aa53cf8
Compare
| * @kind function | ||
| * | ||
| * @description | ||
| * Converts all accepted directives format into proper directive name. |
There was a problem hiding this comment.
In order to keep the "terminology" consistent with the rest of the docs, I would rephraze it to something like:
Converts an attribute name (e.g. dash/colon/underscore-delimited string, optionally prefixed with `x-` or `data-`) to its normalized, camelCase form.
You could also add a link to https://docs.angularjs.org/guide/directive#matching-directives for further info.
cironunes
force-pushed
the
docs-normalize
branch
from
aa53cf8 to
4fc1590
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.