Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(changelog): add test for addition of trailing newline #10358

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Dec 7, 2014

Adds tests for the functionality added by #9550.

(As suggested in #9550 (comment) .)

@googlebot
Copy link

CLAs look good, thanks!

@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

are we actually able to run these tests anymore? node_modules/.bin/jasmine-node changelog.spec.js throws --- some problem loading the lunr.js test helper, which we apparently need?

@gkalpak
Copy link
Member Author

gkalpak commented Dec 8, 2014

I don't think we need the lunr helper.
I was able to run the tests using jasmine-node's --nohelpers switch:

jasmine-node --nohelpers changelog.spec.js

@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

weird, huh

@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

anyway, land it I guess, it looks okay to me

@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

wait, actually no --- one of these tests fails

@gkalpak gkalpak force-pushed the changelog-test-trailing-newline branch from a767244 to 76c6e1e Compare December 8, 2014 18:00
@gkalpak
Copy link
Member Author

gkalpak commented Dec 8, 2014

I had a not in the expectation that shouldn't be there. Fixed.
(It was a left-over from my testing that the tests are actually executed 😄)

@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

yep, just tried it and it's green, lgtm

@gkalpak gkalpak closed this in c5cba6e Dec 8, 2014
@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

merg'd

gkalpak added a commit that referenced this pull request Dec 8, 2014
Adds tests for the functionality added by #9550.

Closes #10358
@caitp
Copy link
Contributor

caitp commented Dec 8, 2014

in the future, commits which are just tests use the test(....): ... notation, per the commit message guidelines --- but it doesn't matter much

@gkalpak gkalpak deleted the changelog-test-trailing-newline branch December 10, 2014 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants