This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http) Don't try to JSON.stringify FormData objects #10373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
| @@ -991,6 +991,15 @@ describe('$http', function() { | |||
| $http({ method: 'POST', url: '/url', data: blob }); | |||
| }); | |||
|
|
|||
| it('should ignore FormData objects', function() { | |||
| if (!window.Blob) return; | |||
There was a problem hiding this comment.
Shouldn't this be window.FormData ?
There was a problem hiding this comment.
Good catch @gkalpak !
There was a problem hiding this comment.
Thanks for noticing that, fixed now.
|
@realityking thnx for the PR, it generally looks good to me. You just need to fix a pb spotted by @gkalpak. Personally I would also change the commit message to sth like |
This won't enable FormData uploads in itself, as the Content-Type is automatically set to application/json.
|
@pkozlowski-opensource I've changed the commit message as well. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't enable FormData uploads in itself, as the Content-Type is automatically set to application/json.