This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($filter): Display Infinity symbol when number is Infinity #10422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinity is a value and should not be treated as an empty string Closes #10421
|
CLAs look good, thanks! |
|
|
||
| var isNegative = number < 0; | ||
| number = Math.abs(number); | ||
|
|
||
| var isInfinity = number === Infinity; | ||
| if (!isInfinity && !isFinite(number)) return ''; |
There was a problem hiding this comment.
This will return '' for -Infinity --- just use IsNaN() imho --- or number !== number
|
@caitp, the build is failing but it seems to be a timeout issue. I guess only admins are able to restart builds. It might not be clear for new contributors (like me). May I suggest adding a few words about this (and what to do if builds are failing) in the contributing guidelines ? |
|
build failure is a flake, were having a lot of those lately (i've restarted it) |
|
It failed again 😖 |
|
it's passed now =] |
|
this would be a small breaking change, but I think it is a nice addition. Let's look at this for 1.4 |
|
landed as 51d6774 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infinity is a value and should not be treated as an empty string
Closes #10421