added ng-jq functionality to be able to force jqLite instead of jQuery if present. #10430
Conversation
…on, haven't had the chance to test bind function just yet
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
| var active = !!(document.querySelector('[ng-csp]') || | ||
| document.querySelector('[data-ng-csp]')); | ||
|
|
||
| if (!active) { |
There was a problem hiding this comment.
Use 2 spaces instead of tabs for indentation.
This applies to most of the changes.
|
CLAs look good, thanks! |
|
@mzgol I fixed the styling to the best of my ability. Can I suggest that there's some kind of automatic 'styler' that can be added to the grunt build to make this easier? Thanks for all your help. |
|
Build issue seems to be related to the e2e testing with saucelabs:
|
|
@mboudreau It seems the Angular CI setup was a little unstable when you were reporting this PR. Would you mind rebasing it over current master so that we get the Travis run on the current setup? Thanks! |
|
Will do. On Thu, Dec 25, 2014, 12:08 PM Michał Gołębiowski notifications@github.com
|
made it very similar to csp() function as it should be global since angular.element is as well. Added some unit tests around the jq() function, but still missing scenario testing which I need some direction on to complete. This is a first attempt and hoping @mzgol can help out more to finish the contribution to the angular.js codebase.