This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($http): pass response status code to data transform functions #10440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
|
status code makes getting "success" or "failure" very easy. It is much more informative than "success" or "fail" |
|
We could add "transformErrorResponse" and call that if it's available --- but send the status code to both functions |
|
yeh... not sure... maybe we shouldn't over-thinking this... people were living without this feature for years and their IMO this is a small thing that we could land in 1.3.x and it would probably cover all the use-cases people might have... |
|
I agree. |
|
Cool. So if you could quickly review we could land it and call it a day :-) |
|
looks good if travis is green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10324
Closes #6734
@caitp this is an alternative to #6734 discussed today. I'm still not sure what it the best: to pass status code or just success / error flag (like in #6734). The first approach is more flexible but people will have to duplicate the
isSuccess"logic".