fix(form): ignore properties in prototype chain in $error #10470

caitp · 2014-12-15T22:00:38Z

googlebot · 2014-12-15T22:00:41Z

CLAs look good, thanks!

lgalfaso · 2014-12-16T10:23:22Z

this will only have a very small performance impact on forEach over objects, this is very much acceptable and makes forEach compatible with createMap. LGTM

lgalfaso · 2015-01-01T19:58:44Z

there were some refactors on input.js and inputSpec.js can you please rebase this?

googlebot added the cla: yes label Dec 15, 2014

caitp added component: forms type: bug labels Dec 15, 2014

caitp force-pushed the issue-10469 branch from b6ee4e9 to 2c5088b Compare December 15, 2014 22:02

fix(form): ignore properties in prototype chain in $error

ada29bb

Closes angular#10469

caitp force-pushed the issue-10469 branch from 2c5088b to ada29bb Compare December 16, 2014 01:58

lgalfaso added this to the 1.3.8 milestone Dec 16, 2014

btford modified the milestones: 1.3.8, 1.3.9 Dec 19, 2014

caitp closed this Jan 12, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(form): ignore properties in prototype chain in $error #10470

fix(form): ignore properties in prototype chain in $error #10470

caitp commented Dec 15, 2014

googlebot commented Dec 15, 2014

lgalfaso commented Dec 16, 2014

lgalfaso commented Jan 1, 2015

fix(form): ignore properties in prototype chain in $error #10470

fix(form): ignore properties in prototype chain in $error #10470

Conversation

caitp commented Dec 15, 2014

googlebot commented Dec 15, 2014

lgalfaso commented Dec 16, 2014

lgalfaso commented Jan 1, 2015