Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf(limitTo): replace for loop with slice #10475

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/ng/filter/limitTo.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ function limitToFilter() {
}
}

var out = [],
i, n;
var i, n;

// if abs(limit) exceeds maximum length, trim it
if (limit > input.length)
Expand All @@ -119,14 +118,13 @@ function limitToFilter() {
i = 0;
n = limit;
} else {
// zero and NaN check on limit - return empty array
if (!limit) return [];

i = input.length + limit;
n = input.length;
}

for (; i < n; i++) {
out.push(input[i]);
}

return out;
return input.slice(i, n);
};
}