docs(ngInclude): describe your change... #10594
Conversation
Using obsolete <tt> HTML tag may not be good for Angular examples
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
| @@ -49,7 +49,7 @@ | |||
| <select ng-model="template" ng-options="t.name for t in templates"> | |||
| <option value="">(blank)</option> | |||
| </select> | |||
| url of the template: <tt>{{template.url}}</tt> | |||
| url of the template: {{template.url}} | |||
There was a problem hiding this comment.
I think it would be good to replace tt with code instead of getting rid of the element completely (it looks better to me) --- otherwise lgtm
There was a problem hiding this comment.
yeh, adding <code> would be much better as compared to simply removing those tags. @rus0000 could you please change <tt> => <code> and sign the CLA so we can merge this one?
|
@rus0000 can you make the change and someone will merge this in? |
|
CLAs look good, thanks! |
|
Replaced tt tag with code |
|
Thanks @rus0000 |
Using obsolete <tt> HTML tag may not be good for Angular examples Closes #10594
Using obsolete <tt> HTML tag may not be good for Angular examples Closes #10594
Using obsolete tt HTML tag may not be good for Angular examples