This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(filterFilter): do not filter objects properly in case a property is an array #10621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,7 +186,7 @@ function deepCompare(actual, expected, comparator, matchAgainstAnyProp, dontMatc | |||
|
|
|||
| if ((expectedType === 'string') && (expected.charAt(0) === '!')) { | |||
| return !deepCompare(actual, expected.substring(1), comparator, matchAgainstAnyProp); | |||
| } else if (actualType === 'array') { | |||
| } else if (isArray(actual)) { | |||
|
Looks correct to me, but could you please fix the indentation in your tests? 2 space indentation |
…is an array In JavaScript, an array is a special type of object, therefore typeof [] returns object. Added corresponding unit tests. Changed condition for array type to isArray.
fealaer
force-pushed
the
fix-for-case-when-actual-is-an-array-in-deep-compare
branch
from
0b6a62e to
3df4285
Compare
|
LGTM, just waiting on travis |
caitp
pushed a commit
that referenced
this pull request
Jan 2, 2015
In JavaScript, an array is a special type of object, therefore typeof [] returns object. Added corresponding unit tests. Changed condition for array type to isArray. Closes #10621
fealaer
deleted the
fix-for-case-when-actual-is-an-array-in-deep-compare
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JavaScript, an array is a special type of object, therefore typeof [] returns object.
Added corresponding unit tests.
Changed condition for array type to isArray.