This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ng-options): support one-time binding on the options #10694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petebacondarwin can you please make sure that the ng-options refactor also passes the tests added here? |
| expect(options.eq(1)).toEqualOption('0', 'a'); | ||
| expect(options.eq(2)).toEqualOption('1', 'b'); | ||
| expect(options.eq(3)).toEqualOption('2', 'c'); | ||
| }); |
There was a problem hiding this comment.
It would be nice to also have a test that verifies correct behaviour when arr is originally undefined.
Preserve the $watchDelegate on the watcher used to detect changes on the labels Closes angular#10687
lgalfaso
force-pushed
the
select-one-time-binding
branch
from
a87910f to
5cb015b
Compare
|
Nice little fix @lgalfaso! I have updated my PR to include this. |
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jan 12, 2015
Utilize the $watchDelegate on the watcher used to detect changes to the labels. Closes angular#10687 Closes angular#10694
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jan 12, 2015
Utilize the $watchDelegate on the watcher used to detect changes to the labels. Closes angular#10687 Closes angular#10694
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the $watchDelegate on the watcher used to detect changes on the labels
Closes #10687