Grammar change #10710
Grammar change #10710
Conversation
Not sure if this is a worthy change but it confused me when I read it. In practice, different from is by far the most common of the three, in both British and American English: http://www.oxforddictionaries.com/us/words/different-from-than-or-to
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
| * | ||
| * Since `ng-model` does not do a deep watch, `$render()` is only invoked if the values of | ||
| * `$modelValue` and `$viewValue` are actually different to their previous value. If `$modelValue` | ||
| * `$modelValue` and `$viewValue` are actually from their previous value. If `$modelValue` |
There was a problem hiding this comment.
i think you want to keep the word "different" here
|
other than that it looks ok, could you please update it and sign the CLA so we can merge it? =] |
|
CLAs look good, thanks! |
|
Done |
|
looks ok to me, should do another one to try to fix the run-on sentences though |
Not sure if this is a worthy change but it confused me when I read it.
"In practice, different from is by far the most common of the three, in both British and American English:"
http://www.oxforddictionaries.com/us/words/different-from-than-or-to