This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Fix(ngRepeat) do not allow $id and $root as aliases
#10778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KELiON
changed the title
as $id and as $root in ng-repeat directive$id and $root as aliases
Currently user can use `$id` or `$root` as alias in ng-repeat directive that leads to rewriting these scope-related variables. This commit fixes this behavior by throwing an error when user try to use these values.
KELiON
changed the title
$id and $root as aliases$id and $root as aliases
KELiON
force-pushed
the
update-ng-repeat-alias
branch
from
4e55344 to
aa4d8cb
Compare
|
LGTM, but just to be sure, @caitp can you take a look at this? |
|
lgtm (note: I am very happy that it's such a small patch to fix this) |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jan 20, 2015
Currently user can use `$id` or `$root` as alias in ng-repeat directive that leads to rewriting these scope-related variables. This commit fixes this behavior by throwing an error when user try to use these values. Closes #10778
|
Thanks! Should we cherry-pick this to 1.3 too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently user can use
$idor$rootas alias in ng-repeat directive that leads to rewriting these scope-related variables. This commit fixes this behavior by throwing an error when user try to use these values.