Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Directives): mentioned shorthand for "return function()" #11180

Closed
wants to merge 1 commit into from

Conversation

zbycz
Copy link

@zbycz zbycz commented Feb 25, 2015

The shorthand is little confusing, added clarification.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@Narretz
Copy link
Contributor

Narretz commented Mar 8, 2015

Hi, thanks for your PR! However, before we can merge we need you to sign the CLA.

@Narretz Narretz added this to the Backlog milestone Mar 8, 2015
@Narretz
Copy link
Contributor

Narretz commented Mar 12, 2015

Imo, we should change the example to use the verbose way of defining a directive. That makes it clearer.

@Narretz Narretz modified the milestones: Ice Box, Backlog Mar 12, 2015
@lgalfaso
Copy link
Contributor

Agree with @Narretz

@zbycz
Copy link
Author

zbycz commented Mar 18, 2015

Quite contrary, i'd like to learn that the shorthand exists - it can be seen in other projects as well. Just the clarification was missing.

@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz closed this in ee6a3cc Mar 21, 2015
Narretz added a commit that referenced this pull request Mar 21, 2015
All the other examples use the full syntax.
Closes #11180
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
All the other examples use the full syntax.
Closes angular#11180
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants