Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Updated the require section to reflect issue 11198 #11206

Closed
wants to merge 1 commit into from

Conversation

bborowin
Copy link
Contributor

To make things less confusing, explicitly state that require WILL NOT cause a compile error if a link function is not specified.

#11198
stackoverflow.com/questions/28730346/require-ddo-option-of-angular-directive-does-not-throw-an-error-when-it-should

To make things less confusing, explicitly state that require WILL NOT cause a compile error if a link function is not specified.

angular#11198
stackoverflow.com/questions/28730346/require-ddo-option-of-angular-directive-does-not-throw-an-error-when-it-should
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@bborowin
Copy link
Contributor Author

CLA signed, thanks botty mc bot

@googlebot
Copy link

CLAs look good, thanks!

@pkozlowski-opensource
Copy link
Member

Woops, it looks like it is not ready to be merged, as it makes TravisCI upset. @bborowin could you please fix the jscs style errors and update the commit message to follow our guidelines? Thnx!

@Narretz Narretz added this to the Backlog milestone Mar 8, 2015
@Narretz Narretz self-assigned this Mar 8, 2015
@Narretz Narretz closed this in 41fdb3d Mar 8, 2015
Narretz pushed a commit that referenced this pull request Mar 8, 2015
To make things less confusing, explicitly state that require
WILL NOT throw a compile error if a link function is not specified.

Closes #11206
stackoverflow.com/questions/28730346/require-ddo-option-of-angular-directive-does-not-throw-an-error-when-it-should
hansmaad pushed a commit to hansmaad/angular.js that referenced this pull request Mar 10, 2015
To make things less confusing, explicitly state that require
WILL NOT throw a compile error if a link function is not specified.

Closes angular#11206
stackoverflow.com/questions/28730346/require-ddo-option-of-angular-directive-does-not-throw-an-error-when-it-should
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
To make things less confusing, explicitly state that require
WILL NOT throw a compile error if a link function is not specified.

Closes angular#11206
stackoverflow.com/questions/28730346/require-ddo-option-of-angular-directive-does-not-throw-an-error-when-it-should
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants