Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(date filter): display localised era for G format code #11266

Closed
wants to merge 4 commits into from
Closed

fix(date filter): display localised era for G format code #11266

wants to merge 4 commits into from

Conversation

petebacondarwin
Copy link
Contributor

Fixes #10503

@petebacondarwin petebacondarwin added this to the 1.4.0-beta.6 / 1.3.15 milestone Mar 6, 2015
@lgalfaso
Copy link
Contributor

the patch is too big, so I cannot see if you modified the built-in locale. If you want to add the long names for eras, please use http://unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table as a reference.
Otherwise, please rebase this and LGTM

@petebacondarwin
Copy link
Contributor Author

@lgalfaso - thanks for taking the time to review. The PR has three commits. You probably want to look at ff69230 and ba38421

@lgalfaso
Copy link
Contributor

LGTM

@petebacondarwin
fix(ng/$locale): add ERA info in generic locale
4acb0af 
This change also updates the closure i18n converter to pull in the ERA
info for generated locale files.
@petebacondarwin
chore(ngLocale): regenerate locale files to include ERA info
68dbbfb
@petebacondarwin
fix(date filter): display localised era for G format code
53c4561 
This implementation is limited to displaying AD years correctly only, since
there is no agreed standard on how to represent dates before 1 AD.

Closes angular#10503
Closes angular#11266
@petebacondarwin
fix(date filter): display localised era for G format code
c7e69fd 
This implementation is limited to displaying AD years correctly only, since
there is no agreed standard on how to represent dates before 1 AD.

Closes angular#10503
Closes angular#11266
@petebacondarwin
Copy link
Contributor Author

Added support for GG, GGG and GGGG
Removed ddescribe
Improved commit msgs

petebacondarwin added a commit that referenced this pull request Mar 11, 2015
@petebacondarwin
fix(date filter): display localised era for G format codes
f2683f9 
This implementation is limited to displaying only AD (CE) years correctly,
since we do not support the `u` style year format that can be used to represent
dates before 1 AD.

Closes #10503
Closes #11266
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@petebacondarwin @netman92
fix(date filter): display localised era for G format codes
1a37bfd 
This implementation is limited to displaying only AD (CE) years correctly,
since we do not support the `u` style year format that can be used to represent
dates before 1 AD.

Closes angular#10503
Closes angular#11266
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: filters severity: inconvenient type: bug
Projects
None yet
Milestone
1.4.0-beta.6 / 1.3.15
Development

Successfully merging this pull request may close these issues.

angular-i18n has wrong dateformat in Thai.
3 participants
@petebacondarwin @lgalfaso @googlebot