feat($compile): Throw error on incorrect casing #11281

wesleycho · 2015-03-09T18:14:16Z

Adds error message for when the first letter of the directive name is
not capitalized in the definition

This addresses #11109 .

lgalfaso · 2015-03-09T23:18:17Z

src/ng/compile.js

@@ -779,6 +779,14 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    return bindings;
  }

+  function assertFirstLetterIsLowerCased(name) {
+    var letter = name.charAt(0);


please use the lowercase function as it handles some locale issues

lgalfaso · 2015-03-11T15:42:40Z

src/ng/compile.js

@@ -779,6 +779,14 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    return bindings;
  }

+  function assertValidDirectiveName(name) {
+    var letter = name.charAt(0);
+    if (letter && (letter !== lowercase(letter))) {


I think this should be if (!letter || letter !== lowercase(letter)) {

- Adds error message for when the first letter of the directive name is not capitalized in the definition - Refactor according to CR - More fixes as per CR - Change back to && - Change back, add missing !

petebacondarwin · 2015-03-17T13:07:51Z

We can't use ng:badname as this refers to using hasOwnProperty where we shouldn't, see https://docs.angularjs.org/error/ng/badname
I'll knock up a new error and merge this. Thanks @wesleycho (and @lgalfaso and @Narretz for reviewing)

petebacondarwin · 2015-03-17T13:19:29Z

Moreover, the test was not actually running, since you have to also request that the injector instantiates the $compile service. You could see that the test was not failing by removing the "fix".

It is better to follow the example of the hasOwnProperty test: https://github.com/angular/angular.js/blob/master/test/ng/compileSpec.js#L196-L203

I will fix this up too.

Directive names must start with a lower case letter. Previously the compiler would quietly fail. This change adds an assertion that fails if this is not the case. Closes #11281 Closes #11109

Directive names must start with a lower case letter. Previously the compiler would quietly fail. This change adds an assertion that fails if this is not the case. Closes angular#11281 Closes angular#11109

googlebot added the cla: yes label Mar 9, 2015

lgalfaso reviewed Mar 9, 2015
View reviewed changes

Narretz added component: $compile needs: work labels Mar 10, 2015

wesleycho force-pushed the feat/error-bad-camelcasing branch from 6389355 to 9d842a1 Compare March 11, 2015 03:12

lgalfaso reviewed Mar 11, 2015
View reviewed changes

feat($compile): Throw error on incorrect casing

4e2e3aa

- Adds error message for when the first letter of the directive name is not capitalized in the definition - Refactor according to CR - More fixes as per CR - Change back to && - Change back, add missing !

wesleycho force-pushed the feat/error-bad-camelcasing branch from e8d33dc to 4e2e3aa Compare March 14, 2015 19:06

petebacondarwin closed this in 89447b3 Mar 17, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat($compile): Throw error on incorrect casing #11281

feat($compile): Throw error on incorrect casing #11281

wesleycho commented Mar 9, 2015

lgalfaso Mar 9, 2015

lgalfaso Mar 11, 2015

petebacondarwin commented Mar 17, 2015

petebacondarwin commented Mar 17, 2015

feat($compile): Throw error on incorrect casing #11281

feat($compile): Throw error on incorrect casing #11281

Conversation

wesleycho commented Mar 9, 2015

lgalfaso Mar 9, 2015

Choose a reason for hiding this comment

lgalfaso Mar 11, 2015

Choose a reason for hiding this comment

petebacondarwin commented Mar 17, 2015

petebacondarwin commented Mar 17, 2015