This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(ci): make wait_for_browser_provider time out after 2 minutes #11350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if something went wrong, wait_for_browser_provider.sh would wait indefinitely, and logs would never get printed. Now, we'll bail early, and get some actual logs on what the problem was.
|
LGTM - merging |
juliemr
added a commit
that referenced
this pull request
Mar 17, 2015
Before, if something went wrong, wait_for_browser_provider.sh would wait indefinitely, and logs would never get printed. Now, we'll bail early, and get some actual logs on what the problem was. Closes #11350
|
and cherry-picked into 1.3.x |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Before, if something went wrong, wait_for_browser_provider.sh would wait indefinitely, and logs would never get printed. Now, we'll bail early, and get some actual logs on what the problem was. Closes angular#11350
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if something went wrong, wait_for_browser_provider.sh would
wait indefinitely, and logs would never get printed. Now, we'll bail
early, and get some actual logs on what the problem was.