This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Ensure boolean values for aria-* attributes #11365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aria-* (e.g. aria-hidden) values should mirror the truthiness of their ng-* counterparts (e.g. ng-show, ng-hide) instead of their actual value
|
Example of a problem: If a user types "bar" into the text field, foo will have a string value of "bar" and ng-show will correctly make the div visible. However, with ngAria module in use, aria-hidden attribute will (without this pull request) also have the value "bar", which is invalid. Instead, we want aria-hidden to mirror the truthiness of ng-show, and just have a value of true or false. |
|
Hi, thanks for the PR. Would you be able to write a test for this? |
|
Just to make sure, @marcysutton do you think this a valid issue? |
|
That does sound valid to me– |
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
May 28, 2015
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
May 28, 2015
aria-hidden should mirror the boolean representation of their ng-* counterpart (ng-show, ng-hide) instead of their actual value Closes angular#11365
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
May 28, 2015
aria-hidden should mirror the boolean representation of their ng-* counterpart (ng-show, ng-hide) instead of their actual value Closes angular#11365
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jun 1, 2015
aria-hidden should mirror the boolean representation of their ng-* counterpart (ng-show, ng-hide) instead of their actual value. Same applies to aria-disabled and ng-disabled Closes angular#11365
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
aria-hidden should mirror the boolean representation of their ng-* counterpart (ng-show, ng-hide) instead of their actual value. Same applies to aria-disabled and ng-disabled Closes angular#11365
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-* (e.g. aria-hidden) values should mirror the truthiness of their ng-*
counterparts (e.g. ng-show, ng-hide) instead of their actual value