This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngTouch): make tests pass on Chrome with touch enabled #11493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `initTouchEvent()` method (introduces in 06a9f0a) did not correctly initialize the event, nor did the event get dispatched on the target element (e.g. on desktop Chrome with touch-events enabled). Using the `Event` constructor and manually attaching a `TouchList`, works around the issue (although not a proper fix).
gkalpak
force-pushed
the
ngTouch-fix-tests-on-chrome-with-touch
branch
from
65a6412 to
7a87394
Compare
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Apr 2, 2015
|
Before merging this, @mzgol suggested making sure that: I submitted #11498 to verify this and indeed tests seem to still fail on iOS (e.g. here and there). /fyi @mzgol, @petebacondarwin |
|
I'll merge |
gkalpak
added a commit
that referenced
this pull request
Apr 2, 2015
…h enabled Chrome On certain browsers (e.g. on desktop Chrome with touch-events enabled), using the `initTouchEvent()` method (introduced in 06a9f0a) did not correctly initialize the event, nor did the event get dispatched on the target element. Using the `Event` constructor and manually attaching a `TouchList`, works around the issue (although not a proper fix). Fixes #11471 Closes #11493
gkalpak
added a commit
that referenced
this pull request
Apr 2, 2015
…h enabled Chrome On certain browsers (e.g. on desktop Chrome with touch-events enabled), using the `initTouchEvent()` method (introduced in 06a9f0a) did not correctly initialize the event, nor did the event get dispatched on the target element. Using the `Event` constructor and manually attaching a `TouchList`, works around the issue (although not a proper fix). Fixes #11471 Closes #11493
gkalpak
changed the title
|
Nice job! |
|
Standing on the shoulders of giants 😛 |
|
But yes, thanks to you and @mzgol for sorting this out. |
|
@petebacondarwin, you are right. I was incorrectly looking for a message mentioning you ;) Deleted the redundant message. |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
…h enabled Chrome On certain browsers (e.g. on desktop Chrome with touch-events enabled), using the `initTouchEvent()` method (introduced in 06a9f0a) did not correctly initialize the event, nor did the event get dispatched on the target element. Using the `Event` constructor and manually attaching a `TouchList`, works around the issue (although not a proper fix). Fixes angular#11471 Closes angular#11493
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
initTouchEvent()method (introduces in 06a9f0a) did not correctly initialize the event, nor did the event get dispatched on the target element (e.g. on desktop Chrome with touch-events enabled).Using the
Eventconstructor and manually attaching aTouchList, works around the issue (although not a proper fix)./ping @mzgol, @petebacondarwin