This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): make sure the JS animation lookup is an object lookup #11640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| provider = $animateProvider; | ||
| }); | ||
| inject(function() { | ||
| expect(provider.$$registeredAnimations['filter']).toBeFalsy(); |
There was a problem hiding this comment.
check for hasOwnProperty instead, it's more generic and also add a comment that we are testing with a well known property name that is usually on objects or arrays, we must ensure that we don't create collisions with them
The lookup type was an array before, but it should be an empty object. Closes angular#11619
|
Merged as 103a39c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lookup type was an array before, but it should be an empty object.
Closes #11619