This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Clarify's test case for ng-repeat stability test. #11761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming Travis now passes (it was flaking previously) then this LGTM |
petebacondarwin
added
type: docs
needs: merging
type: test
and removed
type: docs
labels
petebacondarwin
pushed a commit
that referenced
this pull request
May 5, 2015
The repeated template contained `{{key}}:{{val}}` but the repeat expression
was `"item in items"`, so `key` and `val` were not actually available.
The tests were passing anyway, since they did not rely upon the actual
text content of the template.
Closes #11761
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
The repeated template contained `{{key}}:{{val}}` but the repeat expression
was `"item in items"`, so `key` and `val` were not actually available.
The tests were passing anyway, since they did not rely upon the actual
text content of the template.
Closes angular#11761
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Angular devs,
I was going through the
ng-repeatdirective test cases, and noticed a typo (or at least, I think its a typo) in the setup for the stability test case.Having
{{key}}:{{val}}in the repeated element did not seem to make sense to me, especially when the expression isng-repeat="item in items".Anyways, hope this helps!