This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngJq): update to indicate common pitfall #11780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change docs for ngJq so it mentions that the placement of the directive is important with regards to the angular script. Closes angular#11779
|
It looks good to me. I think fixing the caveat would cause more problems than it's worth, but @petebacondarwin can make a call on that |
|
This LGTM. Feel free to merge. |
|
maybe the wording could be improved a bit, I mean we're starting a sentence with a preposition here, it reads kinda weird. but it's good enough for now, followup wording fixups welcome |
|
Thanks @caitp |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
change docs for ngJq so it mentions that the placement of the directive is important with regards to the angular script. Closes angular#11779 Closes angular#11780
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change docs for ngJq so it mentions that the placement of the directive is important with regards to the angular script.
Closes #11779