This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix(ngOptions): fix frozen ui in ie with more than one select[multiple] #11795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you can see that this fixes the bug on IE and that we are not breaking other browsers by removing then we should merge this. I am trying to remember why both assignments are there in the first place. I have a feeling it was getting around another IE bug. |
Looks like you are right:
|
So we need to find a different solution... |
I haven't looked into a different solution, but I created an e2e test - which doesn't work. It's seems like this is essentially untestable. I have this spec to click on an option inside a select:
and this works! But the bug is that actual clicks from the ui don't work at all on the first select. So we can't even show the bug with an e2e test. |
6df4e56
to
4e1713b
Compare
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Sep 21, 2015
If there is more than one select next to each other, and the first select is wrappend in an element with display: inline or display: inline-block, all but the last select are completely unresponsive to any user input. This cannot be tested in a unit-test or e2e test. Closes angular#11314 Closes angular#11795
4e1713b
to
8579885
Compare
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Sep 22, 2015
If there is more than one select next to each other, and the first select is wrappend in an element with display: inline or display: inline-block, all but the last select are completely unresponsive to any user input. This cannot be tested in a unit-test or e2e test. Closes angular#11314 Closes angular#11795
If there is more than one select next to each other, and the first select is wrappend in an element with display: inline or display: inline-block, all but the last select are completely unresponsive to any user input. This cannot be tested in a unit-test or e2e test. Closes angular#11314 Closes angular#11795
8579885
to
855cf1c
Compare
Narretz
added a commit
that referenced
this pull request
Sep 22, 2015
In certain scenarios, IE10/11/Edge create unresponsive select elements. The following contribute to the bug: - There need to be at least 2 selects next to each other - The option elements are added via javascript - the option.value is accessed before it is set - the option.label is added after the option.value has been set - The first select is wrappend in an element with display: inline or display: inline-block, This cannot be tested in a unit-test or e2e test. Closes #11314 Closes #11795
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are more than one select, and the first select is wrappend
in an element with display: inline or display: inline-block, all but
the last select are completely unresponsive to any user input.
This cannot be tested in a unit-test, as the events must come directly
from the ui.
Close #11314
This is pretty tricky, as we probably need an e2e test for this, but they currently don't run on IE. I'm also not sure if we can simply leave the label setting out.
@petebacondarwin should we wait with this until we have IE e2e tests?