This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngAnimate): generate shared anchor classes between anchor elements as well #11822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts as well Prior to this fix when anchored CSS animations were put to use, only the shared CSS classes between **container** elements were suffixed and applied to the anchor element. This patch now ensures that in addition to the container classes, the shared classes between the starting anchor element and the destination anchor element are prefixed and applied as well.
| @@ -142,7 +139,7 @@ var $$AnimateCssDriverProvider = ['$$animationProvider', function($$animationPro | |||
|
|
|||
| function prepareInAnimation() { | |||
| var endingClasses = filterCssClasses(inAnchor.attr('class')); | |||
|
This has been closed in favour of: #11825 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix when anchored CSS animations were put to use, only the
shared CSS classes between container elements were suffixed and
applied to the anchor element. This patch now ensures that in addition
to the container classes, the shared classes between the starting anchor
element and the destination anchor element are prefixed and applied as
well.