This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): ensure anchored animations remove the leave element at the correct time #11851
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t correct time Due to a mismatch of where the `options.domOperation` value was stored, the element involved in the `leave` animation for an anchored animation session was not removed as soon as the leave animation ended. This resulted in a pending element persisting within the DOM until all animations involved in the associated anchor animation were complete. This patch fixes this issue. Closes angular#11850
|
LGTM |
|
|
|
@Narretz The old test tested for this, but the mocking properties were incorrect. |
|
Merged as 64c66d0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a mismatch of where the
options.domOperationvalue was stored,the element involved in the
leaveanimation for an anchored animationsession was not removed as soon as the leave animation ended. This
resulted in a pending element persisting within the DOM until all
animations involved in the associated anchor animation were complete.
This patch fixes this issue.
Closes #11850