This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): throw an error if a callback is passed to animate met… #11854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods As of bf0f550 (released in 1.3.0) it is no longer valid to pass a callback to the following functions: `enter`, `move`, `leave`, `addClass`, `removeClass`, `setClass` and `animate`. To prevent confusing error messages, this change asserts that this parameter is not a function. Closes angular#11826 Closes angular#11713
|
LGTM |
|
Trouble is that not doing anything leads to a very confusing error, which is hard to track down to having left this callback in place. One thing missing here is actually the error doc. I will add it. |
| @fullName Do not pass a callback to animate methods | ||
| @description | ||
|
|
||
| Since Angular 1.3, the methods of {@link ng.$animate} do not accept a callback as the last parameter. |
There was a problem hiding this comment.
Should we mention that the last parameter now takes the option object?
|
@petebacondarwin make sure to retrofit both the assertion code and the docs so that it can be merged into the 1.3 branch as well. |
|
@matsko - by retrofit you mean backport? |
|
Yessir |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hods
As of bf0f550 (released in 1.3.0) it is no longer
valid to pass a callback to the following functions:
enter,move,leave,addClass,removeClass,setClassandanimate.To prevent confusing error messages, this change asserts that this parameter is
not a function.
Closes #11826
Closes #11713